He entered the Royal Navy in 1888 and was a midshipman, East Indian Station from 1890 to 1893. He was elected as LiberalMember of Parliament (MP) for Greenock in 1910 and sat for the constituency until his death (from 1931 as a Liberal National).
As Secretary of State, he was responsible for over thirty Bills affecting Scotland, chiefly: a scheme for the creation of smallholdings, the Herring Industry Act of 1935 (establishing the Herring Industry Board), the Illegal Trawling (Scotland) Act, the Education (Scotland) Bill of 1936, which sought to raise the school leaving age to fifteen from 1939, and the Housing (Scotland) Act of 1935, which laid down a statutory standard of overcrowding and sought to effect widespread slum clearances and the building of low-rent accommodation for low-wage earners.